This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
[Repository Signing] Don't repository sign package if owner(s) have malformed username #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
joelverhagen,
agr,
xavierdecoster,
shishirx34,
zivkan,
ryuyu,
dtivel,
anangaur,
chenriksson,
cristinamanum,
skofman1,
scottbommarito and
zhhyu
skofman1
reviewed
Jul 30, 2018
| @@ -13,12 +13,15 @@ | |||
| using NuGet.Jobs.Validation.ScanAndSign; | |||
| using NuGet.Services.Validation.Vcs; | |||
| using NuGetGallery; | |||
| using System.Text.RegularExpressions; | |||
There was a problem hiding this comment.
Good catch. Fixed
skofman1
approved these changes
Jul 30, 2018
|
@skofman1 Created this issue to track removing this hack: https://github.com/NuGet/Engineering/issues/1582 |
joelverhagen
added a commit
that referenced
this pull request
Sep 27, 2019
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/NuGet/Engineering/issues/1572