This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Add SymbolsIngester in Orchestrator #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinamanum
requested review from
loic-sharma,
chenriksson,
joelverhagen,
skofman1,
ryuyu,
scottbommarito,
shishirx34,
agr and
zhhyu
shishirx34
reviewed
Aug 1, 2018
| /// 2. Only if a ingestion was not started queue the message to be processed. | ||
| /// 3. After the message is queued, update the SymbolServerRequests table. | ||
| /// </summary> | ||
| /// <param name="request">The request to be send to the ingester job queue.</param> |
| else | ||
| { | ||
| _logger.LogInformation( | ||
| "The symbols ingestion request added to the data base. RequestStatus:{Status} for {PackageId} {PackageNormalizedVersion} {SymbolsPackageKey}.", |
| public class SymbolsIngesterConfiguration : SymbolsValidationConfiguration | ||
| { | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't see this used anywhere.
There was a problem hiding this comment.
It will be used for the configuration in the settings.json file.
| { | ||
| Created = DateTime.UtcNow, | ||
| LastUpdated = DateTime.UtcNow, | ||
| RequestName = validationRequest.PackageKey.ToString(), |
There was a problem hiding this comment.
I do not think we can use the PackageKey as the request name, we cannot push multiple snupkgs for same package otherwise.
There was a problem hiding this comment.
It will be the key for the symbol packages.
shishirx34
approved these changes
Aug 1, 2018
agr
reviewed
Aug 1, 2018
| @@ -55,8 +57,17 @@ | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="NuGet.Services.ServiceBus"> | |||
| <Version>2.26.0-sb-status-34752</Version> | |||
| <Version>2.28.0-sb-morestatus-35915</Version> | |||
There was a problem hiding this comment.
2.28.0-sb-morestatus-35915 [](start = 14, length = 27)
Need a version not from a private branch.
There was a problem hiding this comment.
My mistake. Updated.
joelverhagen
added a commit
that referenced
this pull request
Sep 27, 2019
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
Add the symbols ingester as an Orchestrator validator.
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Orchestrator to queue messages to the symbols ingestion queue.