This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
[Process Signature] Strip valid repository signatures #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
joelverhagen,
agr,
xavierdecoster,
shishirx34,
ryuyu,
dtivel,
chenriksson,
cristinamanum,
skofman1,
scottbommarito and
zhhyu
|
If an admin revalidates a package for another reason, that means the hash will now change, right? This seems like most of the time it is an unintended side-effect. The only time we want this is when the Microsoft owner has the case mismatch. Can't we just re-reposign in a specific case, e.g.
Perhaps in that meeting I missed we decided we don't care about package hash changes? |
|
Talked to @joelverhagen offline. We will enable this feature only for a short window of time so that we can re-reposign Microsoft packages. |
|
🔔 This feature branch is verified on DEV. Please review when possible :) |
joelverhagen
approved these changes
Dec 12, 2018
joelverhagen
added a commit
that referenced
this pull request
Jul 31, 2020
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
Add a config to strip valid repository signatures. This will be used to re-reposign Microsoft packages. Part of https://github.com/NuGet/Engineering/issues/1964
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a config to strip valid repository signatures. This will be used to re-reposign Microsoft packages.
Build: #2272834
Deployment: #8733
Part of https://github.com/NuGet/Engineering/issues/1964