Making sure all license files are packaged for app service deployment. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agr
requested review from
joelverhagen,
loic-sharma,
ryuyu,
drewgillies,
skofman1,
dannyjdev,
zhhyu and
lyndaidaii
zhhyu
approved these changes
Mar 4, 2021
|
@agr , since you are working on licenses, what do you think about this one: https://github.com/NuGet/Engineering/issues/3673 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses NuGet/NuGetGallery#8374.
The issue was that when the initial list of licenses was added, we had to add them to the project as a
Contentto be properly packaged. At the time it was done by listing files one by one. Unfortunately, on subsequent license sync(s) although new files were added toApp_Data\Licenses, they were not added to the project list ofContentfiles.This change replaces explicit file list with a mask that would get all files.