This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
V3 monitoring jobs - add timestamp data to exception thrown #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
approved these changes
Oct 24, 2017
scottbommarito
commented
Oct 25, 2017
| @@ -155,7 +155,7 @@ | |||
| <Compile Include="Utility\NullableNuGetVersionConverter.cs" /> | |||
| <Compile Include="Utility\LogEvents.cs" /> | |||
| <Compile Include="Utility\ILoggerFactoryExtensions.cs" /> | |||
| <Compile Include="Utility\SafeExceptionConverter.cs" /> | |||
| <Compile Include="Utility\SafeExceptionConverter.cs" / | |||
chenriksson
reviewed
Oct 25, 2017
| @@ -155,7 +155,7 @@ | |||
| <Compile Include="Utility\NullableNuGetVersionConverter.cs" /> | |||
| <Compile Include="Utility\LogEvents.cs" /> | |||
| <Compile Include="Utility\ILoggerFactoryExtensions.cs" /> | |||
| <Compile Include="Utility\SafeExceptionConverter.cs" /> | |||
| <Compile Include="Utility\SafeExceptionConverter.cs" / | |||
There was a problem hiding this comment.
Yup, just fixed it.
I resolved a merge conflict using GitHub UI and it appears to have been the culprit
chenriksson
approved these changes
Oct 25, 2017
|
|
||
| namespace NuGet.Services.Metadata.Catalog.Monitoring | ||
| { | ||
| public class TimestampComparisonException : Exception |
There was a problem hiding this comment.
Maybe this should extend ValidationException?
This was referenced Oct 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more debuggability to these issues.