This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
[Azure Search 1] Add DatabaseOwnerFetcher to query for current owner information #501
+106
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
requested review from
agr,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
cristinamanum,
skofman1,
scottbommarito and
zhhyu
joelverhagen
force-pushed
the
jver-owners
branch
from
58329ea to
4b26323
Compare
joelverhagen
added a commit
that referenced
this pull request
Apr 10, 2019
joelverhagen
force-pushed
the
jver-owners
branch
from
4b26323 to
07c8d23
Compare
joelverhagen
added a commit
that referenced
this pull request
Apr 10, 2019
joelverhagen
force-pushed
the
jver-owners
branch
from
07c8d23 to
c3c1cfc
Compare
joelverhagen
added a commit
that referenced
this pull request
Apr 10, 2019
joelverhagen
force-pushed
the
jver-owners
branch
from
c3c1cfc to
efa8530
Compare
joelverhagen
added a commit
that referenced
this pull request
Apr 10, 2019
joelverhagen
force-pushed
the
jver-owners
branch
from
efa8530 to
a0c0ef9
Compare
joelverhagen
added a commit
that referenced
this pull request
Apr 10, 2019
joelverhagen
changed the title
zhhyu
approved these changes
Apr 11, 2019
|
There are two problems with unit tests here:
Because of these hurdles and since the code is small, I chose not to unit test it. |
shishirx34
approved these changes
Apr 11, 2019
loic-sharma
approved these changes
Apr 11, 2019
|
@joelverhagen The |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on NuGet/NuGetGallery#6475.
Query inspired by:
https://github.com/NuGet/NuGet.Jobs/blob/master/src/Search.GenerateAuxiliaryData/SqlScripts/Owners.sql
Progress on NuGet/NuGetGallery#6475