This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
[Package Renames] Add feature flag to disable popularity transfers #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
joelverhagen,
shishirx34,
agr,
cristinamanum,
dannyjdev,
dc7497-1576912,
ryuyu,
skofman1,
xavierdecoster and
zhhyu
April 24, 2020 21:57
shishirx34
approved these changes
Apr 27, 2020
@@ -171,6 +174,19 @@ private async Task<bool> PushIndexChangesAsync() | |||
return true; | |||
} | |||
|
|||
private async Task<SortedDictionary<string, SortedSet<string>>> GetPopularityTransfersAsync() | |||
{ | |||
if (!_featureFlags.IsPopularityTransferEnabled()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: personally I feel an enabled check is more readable and intuitive than not enabled..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the negative pattern as it avoids nesting if there are multiple conditions that must be met before returning the result. For example:
if (condition1)
{
if (condition2)
{
return data;
}
else
{
return errorResult2;
}
}
else
{
return errorResult1;
}
return emptyResults;
Vs:
if (!condition1)
{
return errorResult1;
}
if (!condition2)
{
return errorResult2;
}
return results;
Please let me know if you feel strongly about this.
joelverhagen
approved these changes
Apr 27, 2020
zhhyu
reviewed
Apr 28, 2020
zhhyu
approved these changes
Apr 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the feature flag
Search.TransferPopularity
that, if disabled, removes all popularity transfers on the search index. Note that download overrides are still applied even if the popularity transfer feature flag is disabled.Addresses NuGet/NuGetGallery#7944
The feature flag staleness monitoring is tracked by NuGet/NuGetGallery#7966