VerifyPackage on ApiController should treat version as optional param…

…eter (#3903)
NuGet · May 31, 2017 · 0c290a8 · 0c290a8
1 parent 980958b
commit 0c290a8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/NuGetGallery/Controllers/ApiController.cs b/src/NuGetGallery/Controllers/ApiController.cs
@@ -266,7 +266,7 @@ public async virtual Task<ActionResult> VerifyPackageKeyAsync(string id, string
         private async Task<HttpStatusCodeWithBodyResult> VerifyPackageKeyInternalAsync(User user, Credential credential, string id, string version)
         {
             // Verify that the user has permission to push for the specific Id \ version combination.
-            var package = PackageService.FindPackageByIdAndVersionStrict(id, version);
+            var package = PackageService.FindPackageByIdAndVersion(id, version, semVerLevelKey: SemVerLevelKey.SemVer2);
             if (package == null)
             {
                 return new HttpStatusCodeWithBodyResult(

diff --git a/tests/NuGetGallery.Facts/Controllers/ApiControllerFacts.cs b/tests/NuGetGallery.Facts/Controllers/ApiControllerFacts.cs
@@ -1052,7 +1052,9 @@ internal TestableApiController SetupController(string keyType, string scopes, Pa
 
                 var id = package?.PackageRegistration?.Id ?? "foo";
                 var version = package?.Version ?? "1.0.0";
-                controller.MockPackageService.Setup(s => s.FindPackageByIdAndVersionStrict(id, version)).Returns(package);
+                controller.MockPackageService
+                    .Setup(s => s.FindPackageByIdAndVersion(id, version, SemVerLevelKey.SemVer2, true))
+                    .Returns(package);
 
                 controller.SetCurrentUser(user, scopes);