[A11y] Package Manager tab on Package details reads as both selected …

…and expanded (#9460) * removed aria-expanded to tab item. * remove expanded on bootstrap
NuGet · Apr 11, 2023 · 58fec4c · 58fec4c
1 parent 0efa986
commit 58fec4c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/src/Bootstrap/dist/js/bootstrap.js b/src/Bootstrap/dist/js/bootstrap.js
@@ -2345,14 +2345,12 @@ if (typeof jQuery === 'undefined') {
         .end()
         .find('[data-toggle="tab"]')
           .attr('tabindex', "-1")
-          .attr('aria-expanded', false)
           .attr('aria-selected', false)
 
       element
         .addClass('active')
         .find('[data-toggle="tab"]')
           .attr('tabindex', "0")
-          .attr('aria-expanded', true)
           .attr('aria-selected', true)
 
       if (transition) {

diff --git a/src/Bootstrap/js/tab.js b/src/Bootstrap/js/tab.js
@@ -77,14 +77,12 @@
         .end()
         .find('[data-toggle="tab"]')
           .attr('tabindex', "-1")
-          .attr('aria-expanded', false)
           .attr('aria-selected', false)
 
       element
         .addClass('active')
         .find('[data-toggle="tab"]')
           .attr('tabindex', "0")
-          .attr('aria-expanded', true)
           .attr('aria-selected', true)
 
       if (transition) {

diff --git a/src/NuGetGallery/Views/Packages/DisplayPackage.cshtml b/src/NuGetGallery/Views/Packages/DisplayPackage.cshtml
@@ -184,7 +184,7 @@
 @helper CommandTab(PackageManagerViewModel packageManager, bool active)
 {
     <li role="presentation" class="@(active ? "active" : string.Empty)">
-        <a href="#@packageManager.Id" aria-expanded="@(active ? "true" : "false")"
+        <a href="#@packageManager.Id"
            id="@packageManager.Id-tab" class="package-manager-tab"
            aria-selected="@(active ? "true" : "false")" tabindex="@(active ? "0" : "-1")"
            aria-controls="@packageManager.Id" role="tab" data-toggle="tab"