Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account/Packages page is slow for users with lots of packages #5877

Open
skofman1 opened this issue May 2, 2018 · 4 comments
Open

Account/Packages page is slow for users with lots of packages #5877

skofman1 opened this issue May 2, 2018 · 4 comments

Comments

@skofman1
Copy link
Contributor

skofman1 commented May 2, 2018

For Microsoft account takes ~25 seconds to load.

@skofman1
Copy link
Contributor Author

skofman1 commented May 2, 2018

/cc: @chenriksson

@skofman1
Copy link
Contributor Author

@scottbommarito improved perf significantly by server side perf improvements. However, client side is still slow.

@scottbommarito scottbommarito self-assigned this Dec 21, 2018
@scottbommarito
Copy link
Contributor

Looked at client side. It seems like the majority of the client-side performance issues are related to the fact that the page renders EVERY row of data instead of just what is visible, rather than the Javascript itself being slow.

(I may be wrong here, though, because I am not an expert with performance tooling, and the fact that Knockout was obfuscated/minified made the call stack much more difficult to parse.)

To mitigate this, through Javascript, I added rendering for ONLY rows that are in view, but due to the poor performance of checking the relative locations of thousands of rectangles to the viewport, this performed worse than without the rendering. I think, however, if the code for staggering the rendering of rows was less complex, e.g. by just rendering row by row with a delay between them, we may see an improvement.

Unfortunately, however, I don't have more time to work on this.

@scottbommarito scottbommarito removed their assignment Jan 4, 2019
@joelverhagen
Copy link
Member

My performance fix is verified. The page is still slow (expected) just not as bad as before. I'll keep this issue open since it's still slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants