-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account/Packages page is slow for users with lots of packages #5877
Comments
/cc: @chenriksson |
@scottbommarito improved perf significantly by server side perf improvements. However, client side is still slow. |
Looked at client side. It seems like the majority of the client-side performance issues are related to the fact that the page renders EVERY row of data instead of just what is visible, rather than the Javascript itself being slow. (I may be wrong here, though, because I am not an expert with performance tooling, and the fact that Knockout was obfuscated/minified made the call stack much more difficult to parse.) To mitigate this, through Javascript, I added rendering for ONLY rows that are in view, but due to the poor performance of checking the relative locations of thousands of rectangles to the viewport, this performed worse than without the rendering. I think, however, if the code for staggering the rendering of rows was less complex, e.g. by just rendering row by row with a delay between them, we may see an improvement. Unfortunately, however, I don't have more time to work on this. |
My performance fix is verified. The page is still slow (expected) just not as bad as before. I'll keep this issue open since it's still slow. |
For Microsoft account takes ~25 seconds to load.
The text was updated successfully, but these errors were encountered: