Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Renames] Apply popularity transfers in search #7898

Closed
2 tasks
loic-sharma opened this issue Mar 23, 2020 · 0 comments
Closed
2 tasks

[Package Renames] Apply popularity transfers in search #7898

loic-sharma opened this issue Mar 23, 2020 · 0 comments
Assignees

Comments

@loic-sharma
Copy link
Contributor

loic-sharma commented Mar 23, 2020

Affected jobs:

  • db2azuresearch
  • auxiliary2azuresearch

Part of #7896

@loic-sharma loic-sharma added this to the Sprint 168 - 2020.03.23 milestone Mar 23, 2020
@loic-sharma loic-sharma self-assigned this Mar 23, 2020
@loic-sharma loic-sharma changed the title [Package Renames] Apply popularity transfers [Package Renames] Apply popularity transfers in search Mar 23, 2020
loic-sharma added a commit to NuGet/NuGet.Services.Metadata that referenced this issue Apr 14, 2020
The `auxiliary2azuresearch` job needs to know which popularity transfers have changed to properly update the search index. To do this, the last seen popularity transfers data need to be persisted so that it can be compared against the latest data.

This adds new types `IPopularityTransferDataClient` and `PopularityTransferDataClient` that are unused for now. They will be added to the dependency injection container later.

Part of NuGet/NuGetGallery#7898
loic-sharma added a commit to NuGet/NuGet.Services.Metadata that referenced this issue Apr 14, 2020
The `auxiliary2azuresearch` job needs to know which popularity transfers have changed to properly update the search index.

Previous change: #765
Part of NuGet/NuGetGallery#7898
loic-sharma added a commit to NuGet/NuGet.Services.Metadata that referenced this issue Apr 14, 2020
The `db2azuresearch` and `auxiliary2azuresearch` jobs needs to get the latest popularity transfers from the database.

⚠ This change is not unit testable as it interacts with a database. This will be covered by end-to-end tests and monitoring.

Previous changes: #765 and #766.
Part of NuGet/NuGetGallery#7898
loic-sharma added a commit to NuGet/NuGet.Services.Metadata that referenced this issue Apr 20, 2020
This change introduces a new type, `IDownloadTransferrer`, which determines what downloads should be changed to reflect the latest download overrides. In the future, this type will also apply popularity transfers.

Part of NuGet/NuGetGallery#7898
loic-sharma added a commit to NuGet/NuGet.Services.Metadata that referenced this issue Apr 23, 2020
This updates `auxiliary2azuresearch` to push download changes whenever a popularity transfer changes, or, whenever a download change affects a popularity transfer.

Part of NuGet/NuGetGallery#7898
joelverhagen pushed a commit to NuGet/NuGet.Jobs that referenced this issue Oct 26, 2020
The `auxiliary2azuresearch` job needs to know which popularity transfers have changed to properly update the search index. To do this, the last seen popularity transfers data need to be persisted so that it can be compared against the latest data.

This adds new types `IPopularityTransferDataClient` and `PopularityTransferDataClient` that are unused for now. They will be added to the dependency injection container later.

Part of NuGet/NuGetGallery#7898
joelverhagen pushed a commit to NuGet/NuGet.Jobs that referenced this issue Oct 26, 2020
The `auxiliary2azuresearch` job needs to know which popularity transfers have changed to properly update the search index.

Previous change: NuGet/NuGet.Services.Metadata#765
Part of NuGet/NuGetGallery#7898
joelverhagen pushed a commit to NuGet/NuGet.Jobs that referenced this issue Oct 26, 2020
The `db2azuresearch` and `auxiliary2azuresearch` jobs needs to get the latest popularity transfers from the database.

⚠ This change is not unit testable as it interacts with a database. This will be covered by end-to-end tests and monitoring.

Previous changes: NuGet/NuGet.Services.Metadata#765 and NuGet/NuGet.Services.Metadata#766.
Part of NuGet/NuGetGallery#7898
joelverhagen pushed a commit to NuGet/NuGet.Jobs that referenced this issue Oct 26, 2020
This change introduces a new type, `IDownloadTransferrer`, which determines what downloads should be changed to reflect the latest download overrides. In the future, this type will also apply popularity transfers.

Part of NuGet/NuGetGallery#7898
joelverhagen pushed a commit to NuGet/NuGet.Jobs that referenced this issue Oct 26, 2020
This updates `auxiliary2azuresearch` to push download changes whenever a popularity transfer changes, or, whenever a download change affects a popularity transfer.

Part of NuGet/NuGetGallery#7898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants