Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The API key expiration warning is incorrectly pluralized #8675

Closed
loic-sharma opened this issue Jul 11, 2021 · 0 comments
Closed

The API key expiration warning is incorrectly pluralized #8675

loic-sharma opened this issue Jul 11, 2021 · 0 comments
Assignees
@loic-sharma
Labels
Verified-Dev Verified-Int Verified-Prod
Milestone
Sprint 2021-07

Comments

@loic-sharma
Copy link
Contributor

Describe the bug

If you push a package using an API key that expires in a day you will receive the following warning:

Your API key expires in 1 days. Visit https://www.nuget.org/account/apikeys to regenerate your API key.

The word days is incorrectly pluralized.
@loic-sharma loic-sharma changed the title Fix pluralization of API Key expiration warning The API key expiration warning is incorrectly pluralized Jul 11, 2021
@loic-sharma loic-sharma mentioned this issue Jul 11, 2021
Merged
@loic-sharma loic-sharma added this to the Sprint 2021-07 milestone Jul 11, 2021
@loic-sharma loic-sharma self-assigned this Jul 11, 2021
loic-sharma added a commit that referenced this issue Jul 13, 2021
@loic-sharma
Improve API key expiration warnings (#8676)
ec1271b 
Improve expiration warning messages and adds unit tests.

Addresses #8675
@loic-sharma loic-sharma reopened this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loic-sharma loic-sharma

Labels
Verified-Dev Verified-Int Verified-Prod
Projects
None yet
Milestone
Sprint 2021-07
Development

No branches or pull requests
1 participant
@loic-sharma