Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support service principal #10043

Merged
merged 63 commits into from
Jul 2, 2024
Merged

Support service principal #10043

merged 63 commits into from
Jul 2, 2024

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Jun 26, 2024

Partially addresses: https://github.com/NuGet/Engineering/issues/5448

Add function to support Service principal access blob storage.

it was needed for synthetics jobs cross tenant access.

Tested for one FeatureFlag job in dev

@lyndaidaii lyndaidaii marked this pull request as ready for review June 27, 2024 02:12
@lyndaidaii lyndaidaii requested a review from a team as a code owner June 27, 2024 02:12
@erdembayar
Copy link
Contributor

erdembayar commented Jun 27, 2024

What is the arg-st-sdk-geneva-version feature branch? If there's feature branch why don't we just push into that branch instead of creating PR?

Base automatically changed from agr-st-sdk to dev June 27, 2024 21:29
@lyndaidaii lyndaidaii merged commit 317378a into dev Jul 2, 2024
2 checks passed
@joelverhagen joelverhagen deleted the arg-st-sdk-geneva-version branch August 22, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants