Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tooltip block sitewide accessible and fix warning icon accessibility issue #10060

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Make tooltip block sitewide accessible and fix warning icon accessibility issue #10060

merged 3 commits into from
Jul 11, 2024

Conversation

Goodyear2017
Copy link
Contributor

@Goodyear2017 Goodyear2017 commented Jul 9, 2024 •
edited
Loading

  • Move less and js to site less and js file to make tooltip block sitewide accessible
  • Fixed tooltip block AI4W error
  • Add tooltip block to package waring icon to solve keyboard accessibility issue

Bug URL: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2087242
Result:
image

@Goodyear2017 Goodyear2017 requested a review from a team as a code owner July 9, 2024 21:30
@erdembayar erdembayar requested a review from ryuyu July 9, 2024 22:19
agr
agr previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@agr agr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please remove the extra whitespace added.

drewgillies
drewgillies previously approved these changes Jul 10, 2024
View reviewed changes
ryuyu
ryuyu previously approved these changes Jul 10, 2024
View reviewed changes
@Goodyear2017 Goodyear2017 dismissed stale reviews from ryuyu, drewgillies, and agr via 8394663 July 10, 2024 21:56
@ryuyu ryuyu merged commit 63b2ed2 into NuGet:dev Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryuyu ryuyu ryuyu approved these changes

@agr agr agr approved these changes

@drewgillies drewgillies drewgillies left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Goodyear2017 @agr @ryuyu @drewgillies