Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up build infra to make a repository merge easier #10076

Merged
merged 20 commits into from
Jul 24, 2024
Merged

Conversation

joelverhagen
Copy link
Member

@joelverhagen joelverhagen commented Jul 20, 2024

Similar to NuGet/NuGet.Jobs#1217 and NuGet/ServerCommon#434.

I would like to try a repository merge (monorepo-ish). That is, merging NuGet Server OSS repositories into fewer (perhaps just one). To make this easier, I want to clean up and align our build infra, which is a case where the same file names exist in several repos, making a repo merge have merge conflicts.

Summary of changes

  • Move to Central Package Management
  • Update .gitignore to latest
  • Update .nuget/packages.config (solution level packages), move to root for better visibility
  • Rename SimpleVersion and SemanticVersion to GalleryAssemblyVersion and GalleryPackageVersion
  • Fix some PowerShell functions to use allowed verbs
  • Delete build.cmd, buildandtest.ps1, and several other unused scripts since these are not used by our CI or releases at all.
  • More some stuff from SdkProjects.props to Directory.Build.props so more happens on all projects
  • Clean up NuGet.config to match other repos
  • Fix broken UTs in GitHubVulnerabilities2v3.Facts
  • Fix teammate name in Team.json
  • Move to latest xunit and fix associated warnings/errors (caught several test failures missed before)
  • Align dependency versions with latest across ServerCommon and NuGet.Jobs

@joelverhagen joelverhagen requested a review from a team as a code owner July 20, 2024 23:18
build.ps1 Outdated Show resolved Hide resolved
@joelverhagen joelverhagen reopened this Jul 23, 2024
Copy link
Contributor

@drewgillies drewgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Curious about the significance of analogRelay but that's more a comment.

README.md Show resolved Hide resolved
@joelverhagen
Copy link
Member Author

Beautiful! Curious about the significance of analogRelay but that's more a comment.

A former team member now has a different GitHub username, analogrelay.

@joelverhagen joelverhagen merged commit b779217 into dev Jul 24, 2024
2 checks passed
@joelverhagen joelverhagen deleted the jver-standardize branch July 24, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants