Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PackageVersion in MSBuild to allow different versions at pack time #10124

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

joelverhagen
Copy link
Member

Currently, package references that are converted to project references by our New-ProjectPackage use the same version for all dependencies. This means references to ServerCommon packages in, say, NuGetGallery core would have 4.4.5-blah version which is wrong.

This allows the proper package version to be set on each package not just when it is being packed (already works) but when it is being referred to during pack of another project.

@joelverhagen joelverhagen requested a review from a team as a code owner August 13, 2024 15:32
@joelverhagen joelverhagen merged commit 32b79e8 into dev Aug 13, 2024
2 checks passed
@joelverhagen joelverhagen deleted the jver-package-versions branch August 13, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants