Move to 5.0.0-*, put all dependency packages in NuGet.Server.Common.sln #10130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run simple validations on the .csproj: - Test projects should only be in one solution (all solutions are tests in CI, reduce duplication) - Determine whether a dependency package project common vs. gallery vs. jobs dynamically - Verify AssemblyInfo.g.cs is only written once per project
erdembayar
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a mix of package versions and assemblies for our OSS. Also, we have a mix of release builds the produce dependency packages. This PR simplifies the situation and moves our versions forward so it's clear at a glance you're looking at "a repo merged" state.
Summary of changes:
5.0.0(compiles to5.0.0.0)5.0.0-*to match.build.ps1so we don't shoot ourselves in the footbuild.shared.ps1which we will reduce duplication with our internal build (build_Ev2.ps1)