Introduce delegation SAS #10159
Merged
Introduce delegation SAS #10159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
force-pushed
the
dev-eryondon-delegationSAS
branch
from
116119f to
c1f9128
Compare
src/NuGetGallery.Core/Services/CloudBlobCoreFileStorageService.cs
Outdated
Show resolved
Hide resolved
joelverhagen
previously approved these changes
Aug 30, 2024
erdembayar
force-pushed
the
dev-eryondon-delegationSAS
branch
from
bd3cf4a to
66cfad1
Compare
joelverhagen
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: https://github.com/NuGet/Engineering/issues/5387 and https://github.com/NuGet/Engineering/issues/5433
Introduce delegation SAS, which is more secure than SAK-based SAS.
I didn't reuse or extend the existing SAS generate method and created a new
GetDelegationSasAsyncandGetPrivilegedFileUriWithDelegationSasAsyncbecause I want to be explicit when the customer generates the SAS token and not accidentally consume the old SAK one. Eventually, we can deprecate the SAK-based one without worry later.Also extending the old SAK based on caused API breaking change.