Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BlobServiceClient Constructor #10171

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix BlobServiceClient Constructor #10171

merged 1 commit into from
Sep 5, 2024

Conversation

advay26
Copy link
Member

@advay26 advay26 commented Sep 4, 2024

Fixes a blob service client constructor that was throwing null or whitespace Argument exceptions and causing the Ctalog2Icons job to restart repeatedly.

Had to close the previous PR as that was branched off main, and would have brough in extra commits.

@advay26 advay26 requested a review from a team as a code owner September 4, 2024 23:39
@advay26
Copy link
Member Author

advay26 commented Sep 5, 2024

I deployed Catalog2Icon using these changes and it seems to have worked: https://devdiv.visualstudio.com/DevDiv/_releaseProgress?_a=release-pipeline-progress&releaseId=1548083

Exceptions have stopped and CPU usage is down as well.
image

@advay26 advay26 merged commit 85fb5ce into dev Sep 5, 2024
2 checks passed
@advay26 advay26 deleted the advay26-icons-hotfix branch September 5, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants