Set SendCertificateChain option in KeyVaultReader to enable SN+I authentication
#10179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
reviewed
Sep 10, 2024
| @@ -99,7 +99,19 @@ private SecretClient InitializeClient() | |||
| } | |||
| else | |||
| { | |||
| credential = new ClientCertificateCredential(_configuration.TenantId, _configuration.ClientId, _configuration.Certificate); | |||
| if (_configuration.SendX5c) | |||
There was a problem hiding this comment.
@adityapatwardhan
Do you have a use case for this scenario? Otherwise, we're moving to Managed identity. KV reader is less of a priority for us.
There was a problem hiding this comment.
PowerShell Gallery is planning to use SN+I. We cannot use Managed Identity for now.
There was a problem hiding this comment.
I see. Could you be able to add unit tests covering the new code path?
joelverhagen
approved these changes
Sep 10, 2024
|
Good point on UT coverage from @erdembayar. This is especially important to assert this behavior is needed by PowerShell Gallery. |
joelverhagen
requested changes
Sep 10, 2024
joelverhagen
previously approved these changes
Sep 12, 2024
joelverhagen
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (in less than 80 characters):