NuGet Job, don't rethrow exceptions if blob is not found #10188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdembayar
changed the title
erdembayar
commented
Sep 19, 2024
erdembayar
changed the title
erdembayar
commented
Sep 20, 2024
src/Catalog/Persistence/Storage.cs
Outdated
| @@ -125,6 +127,10 @@ public async Task DeleteAsync(Uri resourceUri, CancellationToken cancellationTok | |||
| { | |||
| await OnDeleteAsync(resourceUri, deleteRequestOptions, cancellationToken); | |||
| } | |||
| catch (RequestFailedException ex) when (ex.ErrorCode == BlobErrorCode.BlobNotFound) | |||
There was a problem hiding this comment.
If necessary I can unit test, let me know
drewgillies
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/NuGet/Engineering/issues/5628
Context is here on teams.
Deployment: 1550336
Previously there was many exceptions for NuGet.Jobs
Catalog2Icon, after deployment it's no more.Before:
After:
