Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating GitHub indexer #10240

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from
Draft

Migrating GitHub indexer #10240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
99fa361
Made initial changes
Jul 11, 2024
f7d018b
Merge branch 'dev' into migrating-github-indexer
Jul 11, 2024
7ac6bb4
Merge remote-tracking branch 'origin/dev' into migrating-github-indexer
Jul 11, 2024
1d1903d
CloudBlobLeaseService using new SDK.
agr Jul 11, 2024
6c090d6
Question mark
agr Jul 11, 2024
dd9f06d
Common storage creation methods.
agr Jul 13, 2024
857e9ee
MSI support.
agr Jul 13, 2024
b41c73d
Typo fix
agr Jul 15, 2024
042f2fc
Merge remote-tracking branch 'origin/agr-stsdk' into migrating-github…
Jul 18, 2024
fd89ec7
Merge branch 'dev' into migrating-github-indexer
Lanaparezanin Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pipelines/Release-trigger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@ steps:
$url = "$(System.CollectionUri)$(System.TeamProject)/_apis/pipelines/${{ pipeline.id }}/runs?api-version=7.0"
Invoke-RestMethod -Uri $url -Method POST -Headers $headers -Body ($body | ConvertTo-Json) -ContentType "application/json"
env:
ACCESS_TOKEN: $(System.AccessToken)
ACCESS_TOKEN: $(System.AccessToken)
8 changes: 4 additions & 4 deletions src/NuGet.Jobs.Common/JobRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ private static async Task<int> Run(JobBase job, string[] commandLineArgs, bool?
commandLineArgs);

// Setup logging
_applicationInsightsConfiguration = ConfigureApplicationInsights(job, jobArgsDictionary);
_applicationInsightsConfiguration = ConfigureApplicationInsights(job, jobArgsDictionary);

// Configure our logging again with Application Insights initialized.
loggerFactory = ConfigureLogging(job, _applicationInsightsConfiguration.TelemetryConfiguration);
Expand Down Expand Up @@ -279,9 +279,9 @@ private static async Task<int> JobLoop(
_logger.LogInformation("Job run took {RunDuration}", PrettyPrintTime(stopWatch.ElapsedMilliseconds));

_applicationInsightsConfiguration.DiagnosticsTelemetryModule?.SetHeartbeatProperty(
HeartbeatProperty_JobLoopExitCode,
exitCode.ToString(),
isHealthy: exitCode == 0);
HeartbeatProperty_JobLoopExitCode,
exitCode.ToString(),
isHealthy: exitCode == 0);
}

if (!runContinuously)
Expand Down
2 changes: 1 addition & 1 deletion src/NuGet.Jobs.Common/StorageAccountExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public static IServiceCollection ConfigureStorageMsi(
string managedIdentityClientId = string.IsNullOrWhiteSpace(configuration[storageManagedIdentityClientIdPropertyName])
? configuration[Constants.ManagedIdentityClientIdKey]
: configuration[storageManagedIdentityClientIdPropertyName];

if (!string.IsNullOrWhiteSpace(useManagedIdentityStr))
{
useManagedIdentity = bool.Parse(useManagedIdentityStr);
Expand Down