Search MSI migration + .NET 9 TFM support #10248
Conversation
| options.Value.StorageConnectionString = options.Value.StorageConnectionString.Replace("SharedAccessSignature=?", "SharedAccessSignature="); | ||
|
|
||
| return new BlobServiceClient(options.Value.StorageConnectionString); | ||
| var storageMsiConfiguration = c.Resolve<IOptionsSnapshot<StorageMsiConfiguration>>(); |
There was a problem hiding this comment.
Do we still need the registration of the BlobServiceClient?
Most of the references in the common stuff should only request BlobServiceClientFactory now, but this registration is probably still necessary if we request the type specifically in any of the search stuff. Otherwise, we can probably clean this up.
Either way, not a huge deal.
There was a problem hiding this comment.
I'm not sure either. This might not be needed any more. I'll try to test it without this and remove it if I can.
I do need to get this work done somewhat soon-ish, so if I feel like I need to move quicker, I'll file this as a follow-up issue and test+remove it later.
| @@ -224,6 +224,39 @@ public static BlobServiceClient CreateBlobServiceClient( | |||
| } | |||
| } | |||
|
|
|||
| public static BlobServiceClientFactory CreateBlobServiceClientFactory( | |||
There was a problem hiding this comment.
👍 I like the idea of handling this at this level.
Addresses https://github.com/NuGet/Engineering/issues/5439
Part of https://github.com/NuGet/Engineering/issues/5512
Config changes PR: https://nuget.visualstudio.com/NuGetMicrosoft/_git/NuGetDeployment/pullrequest/2541
This adds MSI support for the search jobs and the search service.
We also add .NET TFMs to our list of "Supported Frameworks" so that they show up as computed frameworks on the frameworks tab and in the search index. The other changes in the
SupportedFrameworks.csfile were just reordering to make it a bit more readable.I also had to make some tests a bit less sensitive to changes. Earlier we were trying to match an exact list of 'computed' compatible frameworks in some tests. With that setup, we would need to keep updating the test cases every time a new .NET TFM is added. I've made the tests less sensitive now, so they still check for the same behavior, but don't need the test case list to be exhaustive.