Avoid calling CreateIfNotExists for Feature Flags #10258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add related issue link in desc. |
erdembayar
reviewed
Nov 10, 2024
| @@ -598,7 +601,11 @@ private string GetCacheControl(string folderName) | |||
| private async Task<ICloudBlobContainer> PrepareContainer(string folderName, bool isPublic) | |||
| { | |||
| var container = _client.GetContainerReference(folderName); | |||
| await container.CreateIfNotExistAsync(isPublic); | |||
|
|
|||
| if (_initializeContainer) | |||
There was a problem hiding this comment.
What is the actual effect of this? Is it for improving performance by avoiding over the wire call?
There was a problem hiding this comment.
Or was it throwing an exception?
There was a problem hiding this comment.
Because of the CreateIfNotExists call, we were forced to provide 'read-write' permissions to jobs to access Feature Flag storage, even though they only needed 'read' access for these blobs. With this change, those jobs can go back to having just 'read' permissions assigned to them.
erdembayar
approved these changes
Nov 11, 2024
agr
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature flags were calling
CreateIfNotExiststo get the container reference for the FF container ('content'). This container already exists, so we don't need to write anything, but theCreateIfNotExistscall meant that we would need to have read-write permissions enabled regardless, and jobs/services using this path would need the MSI to be over-provisioned (eg. SearchService)I've made changes so we avoid that call for Feature Flags. I've tested it for the SearchService and it worked, but I haven't tested anything else. Let me know if there's anything else I should try to test.
Related to/Part of https://github.com/NuGet/Engineering/issues/5439