Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OIDC 3] Add flight for using federated credentials #10262

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

joelverhagen
Copy link
Member

Progress on #10212.
Depends on #10252.

We want to be able to control exactly which package owners should be using this feature. This adds a flight (i.e. a feature flag specific to the user) for the new federated credentials (OIDC) feature.

I did some minor private const renaming to address an IDE suggestion (per .editorconfig) which is unrelated to the other changes.

The flight defaults to false meaning it is opt-in.

We generally do not have UTs for these changes since they are so simple.

@joelverhagen joelverhagen requested a review from a team as a code owner November 12, 2024 02:18
@joelverhagen joelverhagen merged commit 935a0a5 into dev Nov 12, 2024
2 checks passed
@joelverhagen joelverhagen deleted the jver-oidc-ship branch November 12, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants