Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseBasicParsing on web requests in Powershell #3488

Merged
merged 6 commits into from
Jan 26, 2017
Merged

Conversation

scottbommarito
Copy link
Contributor

If web requests are made without this attribute, they will fail on machines that have not completed first-run configuration of Internet Explorer (VSTS hosted build agents).

@joelverhagen
Copy link
Member

Can you do a build locally using build.ps1 and verify that it doesn't create any pending changes?

@@ -11,7 +11,7 @@ param (
[string]$SemanticVersion = '1.0.0-zlocal',
[string]$Branch,
[string]$CommitSHA,
[string]$BuildBranch = 'bff597e5990a14bb6ca53e371313d54bec48b4a6'
[string]$BuildBranch = '0bedf795cde346cc55f9aa5199914cafd6a4d15a'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this id changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corresponds to a commit in ServerCommon that holds some utility scripts that this uses to run, for example https://github.com/NuGet/ServerCommon/blob/master/build/common.ps1.

@scottbommarito
Copy link
Contributor Author

@joelverhagen Yes.

@scottbommarito scottbommarito merged commit 9a13126 into dev Jan 26, 2017
@scottbommarito scottbommarito deleted the sb-basicparsing branch January 26, 2017 23:53
@joelverhagen joelverhagen mentioned this pull request Jan 27, 2017
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants