Scoped API keys UI - disabled elements are accessible using tab #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skofman1
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
chenriksson,
cristinamanum and
scottbommarito
chenriksson
approved these changes
May 15, 2017
| @@ -721,7 +740,7 @@ | |||
| $('#generateKeyForm').find("input[type=text], textarea").val(""); | |||
| $('#generateKeyForm').find("input:checkbox").removeAttr('checked'); | |||
| setGenerateApiKeyFormInitialState(); | |||
| selectPackageFromGlob($('#addkeyglobPattern'), $('.packagecheckbox input')); | |||
| //selectPackageFromGlob($('#addkeyglobPattern'), $('.packagecheckbox input')); | |||
chenriksson
approved these changes
May 15, 2017
loic-sharma
approved these changes
May 15, 2017
scottbommarito
approved these changes
May 15, 2017
| @@ -721,7 +738,6 @@ | |||
| $('#generateKeyForm').find("input[type=text], textarea").val(""); | |||
| $('#generateKeyForm').find("input:checkbox").removeAttr('checked'); | |||
| setGenerateApiKeyFormInitialState(); | |||
| selectPackageFromGlob($('#addkeyglobPattern'), $('.packagecheckbox input')); | |||
There was a problem hiding this comment.
Why is this no longer necessary?
There was a problem hiding this comment.
no.. there is a cleaner way to "clean" the checkboxes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3962