Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Report Abuse Page #3985

Merged
merged 4 commits into from
May 19, 2017
Merged

Update Report Abuse Page #3985

merged 4 commits into from
May 19, 2017

Conversation

ryuyu
Copy link
Contributor

@ryuyu ryuyu commented May 18, 2017

This PR updates the report abuse page with the following:

  1. Hides the block that only pertains to copyright claims when the report reason is not copyrighting.
  2. Moves validation of Signature to controller from model.
  3. Updates option to read "copyright" instead of "license"
  4. Adds a small blurb about contact via an email address.

See #3792 for more information.

@karann-msft @xavierdecoster @skofman1

@skofman1
Copy link
Contributor

screen shot?

@ryuyu
Copy link
Contributor Author

ryuyu commented May 18, 2017

Not copyright claim:
image

Copyright claim:
image

@@ -16,7 +16,7 @@ public enum ReportPackageReason
[Description("The package contains malicious code")]
ContainsMaliciousCode,

[Description("The package violates a license I own")]
[Description("The package violates a copyright I own")]
ViolatesALicenseIOwn,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the ViolatesALicenseIOwn also be updated to something like ViolatesACopyrightIOwn?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll just change the visible description for now.

@@ -88,6 +88,7 @@
<span class="field-hint-message">Sign with your real name.</span>
@Html.ValidationMessageFor(m => m.Signature)
</div>
<div class="infringement-claim-requirements">You can also send us an email at <a href="mailto:admn@nuget.org">admin@nuget.org</a></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this email right, or should it be admin@nuget.org?

Copy link
Contributor Author

@ryuyu ryuyu May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. It should be admin. Good catch.

@ryuyu ryuyu merged commit d0bc5c0 into dev May 19, 2017
@ryuyu ryuyu deleted the ryuyu-FixReportAbusePage branch July 6, 2017 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants