Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SemVer2 - Missing db index on Packages table #498 #4073

Merged
merged 2 commits into from
Jun 9, 2017
Merged

SemVer2 - Missing db index on Packages table #498 #4073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afe0531
SemVer2 - Missing db index on Packages table #498
xavierdecoster Jun 8, 2017
6d357d7
SemVer2 - Missing db index on Packages table for partial search #499 …
xavierdecoster Jun 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/NuGetGallery/Migrations/201706080632469_AddIndexIsLatestSemVer2.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions src/NuGetGallery/Migrations/201706080632469_AddIndexIsLatestSemVer2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
using System.Data.Entity.Migrations;

namespace NuGetGallery.Migrations
{
public partial class AddIndexIsLatestSemVer2 : DbMigration
{
public override void Up()
{
Sql("IF NOT EXISTS(SELECT * FROM sys.indexes WHERE name = 'nci_wi_Packages_IsLatestSemVer2' AND object_id = OBJECT_ID('Packages')) CREATE NONCLUSTERED INDEX [nci_wi_Packages_IsLatestSemVer2] ON [dbo].[Packages] ([SemVerLevelKey],[Deleted]) INCLUDE ([IsLatest],[IsLatestSemVer2])");
}

public override void Down()
{
Sql("DROP INDEX [nci_wi_Packages_IsLatestSemVer2] ON [dbo].[Packages]");
}
}
}
126 changes: 126 additions & 0 deletions src/NuGetGallery/Migrations/201706080632469_AddIndexIsLatestSemVer2.resx
View file
Open in desktop

Large diffs are not rendered by default.

29 changes: 29 additions & 0 deletions ...llery/Migrations/201706080930506_AddIndexSemVerLevelKeyPackageRegistrationKey.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions src/NuGetGallery/Migrations/201706080930506_AddIndexSemVerLevelKeyPackageRegistrationKey.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
namespace NuGetGallery.Migrations
{
using System;
using System.Data.Entity.Migrations;

public partial class AddIndexSemVerLevelKeyPackageRegistrationKey : DbMigration
{
public override void Up()
{
Sql("IF NOT EXISTS(SELECT * FROM sys.indexes WHERE name = 'nci_wi_Packages_SemVerLevelKey_PackageRegistrationKey' AND object_id = OBJECT_ID('Packages')) CREATE NONCLUSTERED INDEX [nci_wi_Packages_SemVerLevelKey_PackageRegistrationKey] ON [dbo].[Packages] ([SemVerLevelKey],[IsPrerelease],[Deleted]) INCLUDE ([PackageRegistrationKey],[Description],[Tags])");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for these not to be in a single migration?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they were separate PRs, and have been evaluated separately to find out whether the change was for the better or not.

}

public override void Down()
{
Sql("DROP INDEX [nci_wi_Packages_SemVerLevelKey_PackageRegistrationKey] ON [dbo].[Packages]");
}
}
}
126 changes: 126 additions & 0 deletions ...NuGetGallery/Migrations/201706080930506_AddIndexSemVerLevelKeyPackageRegistrationKey.resx
View file
Open in desktop

Large diffs are not rendered by default.

15 changes: 15 additions & 0 deletions src/NuGetGallery/NuGetGallery.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
<MvcBuildViews Condition=" '$(MvcBuildViews)' == '' ">false</MvcBuildViews>
<NuGetPackageImportStamp>
</NuGetPackageImportStamp>
<Use64BitIISExpress />
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols>
Expand Down Expand Up @@ -764,6 +765,14 @@
<Compile Include="Migrations\201706061829243_AddSemVer2LatestVersionColumns.Designer.cs">
<DependentUpon>201706061829243_AddSemVer2LatestVersionColumns.cs</DependentUpon>
</Compile>
<Compile Include="Migrations\201706080632469_AddIndexIsLatestSemVer2.cs" />
<Compile Include="Migrations\201706080632469_AddIndexIsLatestSemVer2.Designer.cs">
<DependentUpon>201706080632469_AddIndexIsLatestSemVer2.cs</DependentUpon>
</Compile>
<Compile Include="Migrations\201706080930506_AddIndexSemVerLevelKeyPackageRegistrationKey.cs" />
<Compile Include="Migrations\201706080930506_AddIndexSemVerLevelKeyPackageRegistrationKey.Designer.cs">
<DependentUpon>201706080930506_AddIndexSemVerLevelKeyPackageRegistrationKey.cs</DependentUpon>
</Compile>
<Compile Include="Security\SecurePushSubscription.cs" />
<Compile Include="Security\IUserSecurityPolicySubscription.cs" />
<Compile Include="OData\Serializers\FeedPackageAnnotationStrategy.cs" />
Expand Down Expand Up @@ -1740,6 +1749,12 @@
<EmbeddedResource Include="Migrations\201706061829243_AddSemVer2LatestVersionColumns.resx">
<DependentUpon>201706061829243_AddSemVer2LatestVersionColumns.cs</DependentUpon>
</EmbeddedResource>
<EmbeddedResource Include="Migrations\201706080632469_AddIndexIsLatestSemVer2.resx">
<DependentUpon>201706080632469_AddIndexIsLatestSemVer2.cs</DependentUpon>
</EmbeddedResource>
<EmbeddedResource Include="Migrations\201706080930506_AddIndexSemVerLevelKeyPackageRegistrationKey.resx">
<DependentUpon>201706080930506_AddIndexSemVerLevelKeyPackageRegistrationKey.cs</DependentUpon>
</EmbeddedResource>
<EmbeddedResource Include="OData\QueryAllowed\Data\apiv1packages.json" />
<EmbeddedResource Include="OData\QueryAllowed\Data\apiv1search.json" />
<EmbeddedResource Include="OData\QueryAllowed\Data\apiv2getupdates.json" />
Expand Down