Add outbound click event tracking for project URL, license URL, and manual download #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
loic-sharma
reviewed
Jun 20, 2017
| $(this).click(function (e) { | ||
| var href = $(this).attr('href'); | ||
| var category = $(this).attr('data-track'); | ||
| if (ga && href && category) { |
There was a problem hiding this comment.
Do you need a e.preventDefault() here? Otherwise wouldn't the link's default behavior just leave the page without waiting for the hitCallback?
There was a problem hiding this comment.
Nice catch. Adding this.
| } | ||
| } | ||
|
|
||
| @using System.Web.Mvc |
There was a problem hiding this comment.
Why does GitHub think this is all changed? At least the first 20 lines look identical to me.
There was a problem hiding this comment.
Whitespace fixes. Try this:
https://github.com/NuGet/NuGetGallery/pull/4240/files?w=1
|
🔔 |
loic-sharma
approved these changes
Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4122