Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard delete of package should delete package owner requests #4898

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Hard delete of package should delete package owner requests #4898

merged 1 commit into from
Oct 25, 2017

Conversation

scottbommarito
Copy link
Contributor

@loic-sharma
Copy link
Contributor

Why don't we have a one-to-many relationship between a package registration and its package owner requests?

@scottbommarito scottbommarito merged commit 7e72e47 into dev Oct 25, 2017
@scottbommarito scottbommarito deleted the sb-deleteownerrequests branch October 25, 2017 18:08
@scottbommarito
Copy link
Contributor Author

@loic-sharma We should. This is just a quick fix for that problem (and also the problem that PackageRegistrationOwners doesn't have the relationship either).

This was referenced Oct 30, 2017
Closed
Merged
@chenriksson chenriksson mentioned this pull request Oct 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shishirx34 shishirx34 shishirx34 approved these changes

@loic-sharma loic-sharma loic-sharma approved these changes

@joelverhagen joelverhagen joelverhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottbommarito @loic-sharma @joelverhagen @shishirx34