Cleanup #6310
Merged
Cleanup #6310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
skofman1
commented
Aug 14, 2018
skofman1
commented
- Removed broken AppVeyor integration
- Removed unused PagerDuty settings
- Cleaned up + updated deployment instructions
skofman1
commented
Aug 14, 2018
| @@ -135,7 +131,7 @@ | |||
| <add key="Gallery.Brand" value="NuGet Gallery"/> | |||
| <add key="Gallery.GalleryOwner" value="NuGet Gallery <support@nuget.org>"/> | |||
| <add key="Gallery.GalleryNoReplyAddress" value="NuGet Gallery <noreply@nuget.org>"/> | |||
| <add key="Gallery.ConfirmEmailAddresses" value="true"/> | |||
| <add key="Gallery.ConfirmEmailAddresses" value="false"/> | |||
There was a problem hiding this comment.
Having 'true' as default creates a bad experience for local deployments/web app deployments. Doesn't make sense to require confirmation if SMTP is not configured..
There was a problem hiding this comment.
This may make #5509 more obvious.
skofman1
requested review from
joelverhagen,
loic-sharma,
shishirx34,
zivkan,
ryuyu,
scottbommarito and
zhhyu
ryuyu
approved these changes
Aug 15, 2018
scottbommarito
approved these changes
Aug 15, 2018
README.md
Outdated
| @@ -49,6 +47,10 @@ You can undo this with this command: | |||
|
|
|||
| This should help prevent unwanted file commits. | |||
|
|
|||
| ## Deploy | |||
|
|
|||
| You will find [here](https://github.com/NuGet/NuGetGallery/blob/master/docs/Deploying/README.md) instructions on how to deploy the Gallery to Azure. | |||
There was a problem hiding this comment.
nit: the more typical way to say this is
You will find instructions on how to deploy the Gallery to Azure [here](https://github.com/NuGet/NuGetGallery/blob/master/docs/Deploying/README.md).
| @@ -135,7 +131,7 @@ | |||
| <add key="Gallery.Brand" value="NuGet Gallery"/> | |||
| <add key="Gallery.GalleryOwner" value="NuGet Gallery <support@nuget.org>"/> | |||
| <add key="Gallery.GalleryNoReplyAddress" value="NuGet Gallery <noreply@nuget.org>"/> | |||
| <add key="Gallery.ConfirmEmailAddresses" value="true"/> | |||
| <add key="Gallery.ConfirmEmailAddresses" value="false"/> | |||
There was a problem hiding this comment.
This may make #5509 more obvious.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.