Fixed breadcrumb links for packages with build metadata

[rocklan]

Fixes breadcrumb links for packages with build metadata:

The only question now is if we want to continue to display the build metadata in the link (the +6...) part. I think it's ok, but that's me.

Addresses #8136

[joelverhagen]

Thanks for the contribution @rocklan 🏆!
Let's ensure the null behavior doesn't cause problems.

[joelverhagen]

Would it be possible to get a unit test to cover this case?

[rocklan]

Would it be possible to get a unit test to cover this case?

I've added a unit test to cover this in the ThePackageBaseHelperMethod class. And having done so, I can see how this bug snuck in. There is already a test to cover this exact scenario, inside the ThePackageHelperMethod class, but the problem is it calls one of the overloads of Package, where a Package object is passed through, and this function passes through the package.NormalizedVersion. However the code that renders the breadcrumbs doesn't call this method, it calls the one that accepts two strings, and it passes though the raw version instead of the normalised one. I don't think calling normalize() twice will cause any issues.

[joelverhagen]

Awesome, thanks so much! The unit test is 💯

[joelverhagen]

Hey, it looks like this test is failing on your branch (per CI):

##[error]    NuGetGallery.ApiControllerFacts+TheGetStatsDownloadsAction.VerifyRecentPopularityStatsDownloads [FAIL]

      unexpected content result[3].Gallery
      Expected: True
      Actual:   False
      Stack Trace:
        tests\NuGetGallery.Facts\Controllers\ApiControllerFacts.cs(0,0): at NuGetGallery.ApiControllerFacts.TheGetStatsDownloadsAction.<VerifyRecentPopularityStatsDownloads>d__0.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
```

[rocklan]

Hey, it looks like this test is failing on your branch (per CI): NuGetGallery.ApiControllerFacts+TheGetStatsDownloadsAction.VerifyRecentPopularityStatsDownloads [FAIL]

I've committed a fix for this, it was previously checking that the version number on the end of a link was 1.1 but now as they are normalized it should be checking for 1.1.0

[joelverhagen]

Awesome, thanks for this contribution @rocklan! 🥇