-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[A11y]Fixing a missed horizontal scroll bar case #8353
Conversation
Do we need to update these snippets as well? NuGetGallery/src/NuGetGallery/Views/Users/_UserAccountChangeExternalCredential.cshtml Lines 72 to 80 in 41db291
NuGetGallery/src/NuGetGallery/Views/Users/_UserAccountChangeExternalCredential.cshtml Lines 84 to 89 in 41db291
|
@@ -30,10 +30,10 @@ | |||
@Html.AntiForgeryToken() | |||
|
|||
<div class="login-account-row"> | |||
<span> | |||
<span class="col-sm-9" style="padding: 0;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's with the padding: 0
? Do these spans need to be wrapped by a <div class="row"> ... </div>
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that and it behaved very strangely. Currently, overriding this for this line was the most robust solution in practice in terms of reflow. btn-block appears to make the button behave oddly for reflowing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good eye @lyndaidaii ! I noticed when testing on dev that I forgot to push a CSS change that needs to accompany this. It is now pushed.
Good catch on those snippets @loic-sharma |
Fixing https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1188115 being reopened.