Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y]Fixing a missed horizontal scroll bar case #8353

Merged
merged 3 commits into from
Jan 14, 2021
Merged

Conversation

ryuyu
Copy link
Contributor

@ryuyu ryuyu commented Dec 15, 2020

@loic-sharma
Copy link
Contributor

Do we need to update these snippets as well?

<span>
Two-factor authentication is currently enabled <i class="ms-Icon ms-Icon--CheckMark checkmark-icon" aria-hidden="true"></i>
</span>
<span class="col-sm-3">
<button class="btn btn-danger btn-block" type="submit"
data-confirm="This action will disable 2FA, making your account less secure. Are you sure you want to disable this setting?">
Disable
</button>
</span>

<span>
Two-factor authentication is currently disabled <i class="ms-Icon ms-Icon--Warning warning-icon" aria-hidden="true"></i>
</span>
<span class="col-sm-3">
<button class="btn btn-default btn-block" type="submit">Enable</button>
</span>

@@ -30,10 +30,10 @@
@Html.AntiForgeryToken()

<div class="login-account-row">
<span>
<span class="col-sm-9" style="padding: 0;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the padding: 0? Do these spans need to be wrapped by a <div class="row"> ... </div> or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that and it behaved very strangely. Currently, overriding this for this line was the most robust solution in practice in terms of reflow. btn-block appears to make the button behave oddly for reflowing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aslo not sure padding: 0 here, I tried build your changes locally, it appears display improperly
Capture

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye @lyndaidaii ! I noticed when testing on dev that I forgot to push a CSS change that needs to accompany this. It is now pushed.

@ryuyu
Copy link
Contributor Author

ryuyu commented Dec 15, 2020

Good catch on those snippets @loic-sharma
Updated.

@ryuyu ryuyu merged commit 2f88fd9 into dev Jan 14, 2021
@zhhyu zhhyu mentioned this pull request Jan 28, 2021
17 tasks
@ryuyu ryuyu deleted the ryuyu-fix-accountscroll branch March 16, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants