[nonGallery] Fix break in githubvulnerabilities2db dependency injection #8516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewgillies
requested review from
agr,
dannyjdev,
joelverhagen,
loic-sharma,
lyndaidaii,
ryuyu,
shishirx34,
skofman1,
xavierdecoster and
zhhyu
as code owners
joelverhagen
approved these changes
Apr 9, 2021
joelverhagen
reviewed
Apr 9, 2021
| using System.Web; | ||
| using NuGetGallery; | ||
|
|
||
| namespace GitHubVulnerabilities2Db.Fakes |
There was a problem hiding this comment.
Consider putting these fake implementations in one of the shared projects.
There was a problem hiding this comment.
Discussed offline. Will come back to that thought later if we see the need.
loic-sharma
approved these changes
Apr 9, 2021
lyndaidaii
approved these changes
Apr 9, 2021
drewgillies
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address: #8515
Dependency injection was broken by the inclusion of the feature flag service in the package service constructor. Added a fake type for this and moved it and an additional fake into a fakes directory.
[this surfaced in BCDR analysis]