[nonGallery] Ingest withdrawn data in GitHub GraphQL #8544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
approved these changes
Apr 23, 2021
skofman1
reviewed
Apr 23, 2021
| nextAdvisory.UpdatedAt = advisory.UpdatedAt; | ||
| nextAdvisory.WithdrawnAt = advisory.WithdrawnAt; |
There was a problem hiding this comment.
Will this cause a vulnerability to stop showing up on PackageDetails page? V3 feed?
There was a problem hiding this comment.
Yes, that's right. It's a deletion in the db.
There was a problem hiding this comment.
The deletion in the DB will flow to V3 only if the package edit time gets updated (as far as I know). Will it be?
There was a problem hiding this comment.
Yes--withdrawn advisories (and I've just sanity-tested this) enter the remove side of this block, and any package added to this collection will have its lastedited time updated:
shishirx34
approved these changes
Apr 26, 2021
agr
approved these changes
May 26, 2021
drewgillies
force-pushed
the
dg-ingresswithdrawndata
branch
from
dea91d7
to
4cb4bed
Compare
drewgillies
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #8474
All of the logic exists in the service and UTs for processing the withdrawn field, but it needs to be added to the query.
Note that there are no withdrawn advisories for NuGet packages at this time, but we need this in place.