Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added warning banner for owners that description is in README tab #8656

Merged
merged 5 commits into from
Jun 25, 2021
Merged

Added warning banner for owners that description is in README tab #8656

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86c2fc6
Added warning to let package owners know that the package description…
sophiamfavro Jun 22, 2021
57fdf26
changed the wording and linked to docs on readme practices
sophiamfavro Jun 23, 2021
4c66c74
added line for styling purposes
sophiamfavro Jun 24, 2021
a199b2c
changed wording to meet styling standards
sophiamfavro Jun 24, 2021
38c325d
improved message to make sense without links
sophiamfavro Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/NuGetGallery/Views/Packages/DisplayPackageV2.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,11 @@
}
else if (!Model.Deleted && !String.IsNullOrWhiteSpace(Model.Description))
{
if (Model.CanDisplayPrivateMetadata)
{
@ViewHelpers.AlertWarning(@<text>The package description is shown below. Please update your package to <a href='https://docs.microsoft.com/nuget/nuget-org/package-readme-on-nuget-org'>include a README</a>.</text>);
}
sophiamfavro marked this conversation as resolved.
Show resolved Hide resolved

<p>@Html.PreFormattedText(Model.Description, Config)</p>
}
</div>
Expand Down