-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AccountDeleter]Adding stubbed definition for missing DI objects. #8677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add a test that verifies the DI container doesn't have issues at runtime?
|
||
using NuGet.Services.Entities; | ||
using System; | ||
using System.Collections.Generic; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: The order of dependencies?
How would i go about doing this? Just have a test that attempts to hydrate the full real objects? That would require a full configuration for test, which I'm not against, but would be more work. Or if there is a simpler way, this sounds like a great idea. |
Can you create a test that uses the |
I filed #8700 for adding this test. I had a bit of difficulty immediately. I'll look into pulling it in when possible. |
Stubs out a minimal FeatureFlagService (used by PackageService) to allow DI to proceed successfully.