Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin panel for bulk unlisted or relisting packages #8691

Merged
merged 16 commits into from
Jul 23, 2021

Conversation

joelverhagen
Copy link
Member

@joelverhagen joelverhagen commented Jul 17, 2021

This uses the same logic as deprecation to allow many changes to packages to be done at once, efficiently.

image

  • You can search for any number of IDs or versions, but upon submission they are processed in batches grouped by ID, where one "update is latest booleans" call is needed
  • Packages that already have the matching listed status are still processed. There is no no-op. This is to allow a simple reflow of listed status.
  • I tested on DEV with 1000, 2000, and 5000 versions of a single package ID. Worked great.

@joelverhagen joelverhagen changed the title [DRAFT] Add admin panel for bulk unlisted or relisting packages Add admin panel for bulk unlisted or relisting packages Jul 21, 2021
@joelverhagen joelverhagen marked this pull request as ready for review July 21, 2021 17:54
@joelverhagen joelverhagen requested a review from a team as a code owner July 21, 2021 17:54
Copy link
Contributor

@shishirx34 shishirx34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this merged in, so that we can use it to handle the spam packages.

@zhhyu
Copy link
Contributor

zhhyu commented Jul 23, 2021

using System.Threading.Tasks;

nit: the order of dependencies.


Refers to: src/NuGetGallery.Services/PackageManagement/PackageUpdateService.cs:9 in 374a79e. [](commit_id = 374a79e, deletion_comment = False)

joelverhagen and others added 2 commits July 23, 2021 10:05
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
@joelverhagen joelverhagen merged commit 91148d2 into dev Jul 23, 2021
@joelverhagen joelverhagen deleted the jver-bulk-unlist branch July 23, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants