Add role attributes to reserved checkmarks #8746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewgillies
changed the title
drewgillies
force-pushed
the
dg-add-checkmark-a11y-tags
branch
from
4caf46e to
5c2a368
Compare
ryuyu
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8743
Behavior of the checkmarks is unchanged, attributes added (which may support screen readers that we don't test). We've tested Windows Narrator and NVDA. These new attributes satisfy compliance requirements.
Note that a lot of suggested compliance changes resulted in screen readers reading text twice--adding
role="presentation"seems to be the cleanest fix.