[A11y] Change role attribute of Recaptcha iframe #9306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9300
Problem:
Th Recaptcha iframes on pages like the Forgot Password page and the Report Abuse page were marked with the role
presentation
by default, but this role (as well as thenone
role) disables some accessibility properties, which is why FastPass was flagging it.Previously,
Fix:
Iframes are only allowed to be marked with the roles
document
,application
orimg
(alsopresentation
ornone
, but that causes other a11y problems). I changed the role of this iframe todocument
, and it clears FastPass checks now (on both the pages flagged in the bug, the Forgot Password page and the Report Abuse page).After the changes,