Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y][Fastpass] Remove aria-expanded attribute where not allowed #9348

Merged
merged 1 commit into from
Jan 11, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove aria-expanded attribute
  • Loading branch information
keylime-unicorn committed Jan 11, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 73529fede2defbd1c4bfbf298915bff86a2b5625
2 changes: 0 additions & 2 deletions src/NuGetGallery/Scripts/gallery/async-file-upload.js
Original file line number Diff line number Diff line change
@@ -251,7 +251,6 @@
var reportContainerElement = document.createElement("div");
$(reportContainerElement).attr("id", "verify-package-block");
$(reportContainerElement).attr("class", "collapse in");
$(reportContainerElement).attr("aria-expanded", "true");
$(reportContainerElement).attr("data-bind", "template: { name: 'verify-metadata-template', data: data }");
$("#verify-package-container").append(reportContainerElement);
ko.applyBindings({ data: model }, reportContainerElement);
@@ -267,7 +266,6 @@
var submitContainerElement = document.createElement("div");
$(submitContainerElement).attr("id", "submit-block");
$(submitContainerElement).attr("class", "collapse in");
$(submitContainerElement).attr("aria-expanded", "true");
$(submitContainerElement).attr("data-bind", "template: { name: 'submit-package-template', data: data }");
$("#submit-package-container").append(submitContainerElement);
ko.applyBindings({ data: model }, submitContainerElement);
1 change: 0 additions & 1 deletion src/NuGetGallery/Scripts/gallery/page-edit-readme.js
Original file line number Diff line number Diff line change
@@ -237,7 +237,6 @@ var BindReadMeDataManager = (function () {
var readMeContainerElement = document.createElement("div");
$(readMeContainerElement).attr("id", "import-readme-block");
$(readMeContainerElement).attr("class", "collapse in");
$(readMeContainerElement).attr("aria-expanded", "true");
$(readMeContainerElement).attr("data-bind", "template: { name: 'import-readme-template', data: data }");
$("#import-readme-container").append(readMeContainerElement);
ko.applyBindings({ data: model }, readMeContainerElement);