Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme link #9358

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Update readme link #9358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0fb338c
update reference link
lyndaidaii Jan 24, 2023
1cc2264
a
lyndaidaii Jan 24, 2023
fb64478
update string.desinger
lyndaidaii Jan 24, 2023
29ca822
update unit test
lyndaidaii Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/NuGetGallery/Strings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/NuGetGallery/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,10 +539,10 @@ For more information, please contact '{2}'.</value>
<value>The Documentation URL must be a raw Markdown file hosted on GitHub.</value>
</data>
<data name="UploadPackage_MissingReadmeHtml" xml:space="preserve">
<value>&lt;strong&gt;Readme&lt;/strong&gt; missing.&lt;a href="https://learn.microsoft.com/nuget/create-packages/package-authoring-best-practices#readme"&gt; See how to include a readme file within the package&lt;/a&gt;, or add it as you upload.</value>
<value>&lt;strong&gt;Readme&lt;/strong&gt; missing.&lt;a href="https://aka.ms/nuget-include-readme"&gt; See how to include a readme file within the package&lt;/a&gt;, or add it as you upload.</value>
</data>
<data name="UploadPackage_MissingReadme" xml:space="preserve">
<value>Readme missing. Go to https://learn.microsoft.com/nuget/create-packages/package-authoring-best-practices#readme learn How to include a readme file within the package.</value>
<value>Readme missing. Go to https://aka.ms/nuget-include-readme learn How to include a readme file within the package.</value>
</data>
<data name="ReservedNamespace_OwnerAdded" xml:space="preserve">
<value>The user '{0}' is now an owner of the prefix '{1}'.</value>
Expand Down
8 changes: 4 additions & 4 deletions tests/NuGetGallery.Facts/Services/PackageMetadataValidationServiceFacts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,8 +1500,8 @@ public async Task WarnsAboutPackagesWithoutReadmeWhenDisplayUploadWarningV2Enabl
Assert.Null(result.Message);
var warning = Assert.Single(result.Warnings);
Assert.IsType<UploadPackageMissingReadme>(warning);
Assert.StartsWith("Readme missing. Go to https://learn.microsoft.com/nuget/create-packages/package-authoring-best-practices#readme learn How to include a readme file within the package.", warning.PlainTextMessage);
Assert.StartsWith("<strong>Readme</strong> missing.<a href=\"https://learn.microsoft.com/nuget/create-packages/package-authoring-best-practices#readme\"> See how to include a readme file within the package</a>, or add it as you upload.", warning.RawHtmlMessage);
Assert.StartsWith("Readme missing. Go to https://aka.ms/nuget-include-readme learn How to include a readme file within the package.", warning.PlainTextMessage);
Assert.StartsWith("<strong>Readme</strong> missing.<a href=\"https://aka.ms/nuget-include-readme\"> See how to include a readme file within the package</a>, or add it as you upload.", warning.RawHtmlMessage);
}

[Fact]
Expand All @@ -1527,8 +1527,8 @@ public async Task WarnsAboutPackagesWithoutWhenEmbeddedReadmeNotEnabledAndDispla
Assert.Null(result.Message);
var warning = Assert.Single(result.Warnings);
Assert.IsType<UploadPackageMissingReadme>(warning);
Assert.StartsWith("Readme missing. Go to https://learn.microsoft.com/nuget/create-packages/package-authoring-best-practices#readme learn How to include a readme file within the package.", warning.PlainTextMessage);
Assert.StartsWith("<strong>Readme</strong> missing.<a href=\"https://learn.microsoft.com/nuget/create-packages/package-authoring-best-practices#readme\"> See how to include a readme file within the package</a>, or add it as you upload.", warning.RawHtmlMessage);
Assert.StartsWith("Readme missing. Go to https://aka.ms/nuget-include-readme learn How to include a readme file within the package.", warning.PlainTextMessage);
Assert.StartsWith("<strong>Readme</strong> missing.<a href=\"https://aka.ms/nuget-include-readme\"> See how to include a readme file within the package</a>, or add it as you upload.", warning.RawHtmlMessage);
}

private async Task<PackageValidationResult> ValidatePackageWithReadme(string readmePath, byte[] readmeFileData)
Expand Down