Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WCP]alt attribute for img tag #9404

Merged
merged 2 commits into from
Feb 28, 2023
Merged

[WCP]alt attribute for img tag #9404

merged 2 commits into from
Feb 28, 2023

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Feb 24, 2023

Summary of the changes (in less than 80 characters):

use reg to add alt = image to fix accessibility.

This is short term quick fix. we need come up a better long-term solution.
For now, image just temporary image description.

Addresses https://github.com/NuGet/Engineering/issues/4784
Issue created here to track for long term solution: #9405

@lyndaidaii lyndaidaii marked this pull request as ready for review February 24, 2023 22:18
@lyndaidaii lyndaidaii requested a review from a team as a code owner February 24, 2023 22:18
Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments

Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please track an issue (NuGet/NuGetGallery is fine) so we can take a better approach. Ideally package authors know about this problem and can remediate their own READMEs so they are more accessible. We can maybe block, maybe warn. Design required :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants