Disallow aria-expanded for collapsible elements without an allowed role #9464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advay26
reviewed
Apr 12, 2023
|
Is this PR based on |
keylime-unicorn
force-pushed
the
tt-aria-expanded
branch
from
512d00a
to
906f87e
Compare
|
rebased with dev branch and fixed true/false bug |
advay26
approved these changes
Apr 12, 2023
lyndaidaii
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9415
Added a fix to the JavaScript that controls collapsible elements to not add the
aria-expandedattribute for elements that do not have an allowed role.