Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin panel for adding/remove user email address for password authentication. #9468

Merged
merged 17 commits into from
May 12, 2023

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Apr 17, 2023

Summary of the changes (in less than 80 characters):

  • Show list of exception list for password authentication
  • Remove/Add email from exception list
  • View the user credential if is IsAADorMACredential
rec-screen.1.webm

Addresses https://github.com/NuGet/Engineering/issues/4731

@lyndaidaii lyndaidaii requested a review from a team as a code owner April 17, 2023 19:25
Copy link
Contributor

@keylime-unicorn keylime-unicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some of the added files are missing the copyright header comment.

@lyndaidaii lyndaidaii changed the title admin panel for adding/remove user email address for password authentication. Admin panel for adding/remove user email address for password authentication. Apr 20, 2023
@lyndaidaii
Copy link
Contributor Author

lyndaidaii commented Apr 27, 2023

Next steps:
we will have separate PRs for following:

  1. Add Aduit
  2. We have another admin panel for allowlist, during that work, we are going to refactor the code since feature flags, email, allowlist are all read, write from storage container. we will build more general base function so that 3 services could use and reduce duplicate code.

@lyndaidaii
Copy link
Contributor Author

@joelverhagen , @zhhyu , @TheoT12 could you help review again since I applied some changes. Thanks!

joelverhagen
joelverhagen previously approved these changes May 9, 2023
agr
agr previously approved these changes May 9, 2023
@lyndaidaii lyndaidaii dismissed stale reviews from agr and joelverhagen via 389ac65 May 10, 2023 22:13
@lyndaidaii
Copy link
Contributor Author

@agr , @TheoT12 addressed your comments, please let me know if you have any questions/comments.

@lyndaidaii lyndaidaii merged commit 2c50dff into dev May 12, 2023
@joelverhagen joelverhagen deleted the adminPanel branch August 22, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants