-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin panel for adding/remove user email address for password authentication. #9468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyndaidaii
commented
Apr 17, 2023
src/NuGetGallery.Core/Login/EditableLoginConfigurationFileStorageService.cs
Outdated
Show resolved
Hide resolved
lyndaidaii
commented
Apr 17, 2023
src/NuGetGallery.Core/Login/EditableLoginConfigurationFileStorageService.cs
Outdated
Show resolved
Hide resolved
lyndaidaii
commented
Apr 17, 2023
src/NuGetGallery.Core/Login/EditableLoginConfigurationFileStorageService.cs
Outdated
Show resolved
Hide resolved
src/NuGetGallery.Core/Login/EditableLoginConfigurationFileStorageService.cs
Show resolved
Hide resolved
src/NuGetGallery.Core/Login/EditableLoginConfigurationFileStorageService.cs
Outdated
Show resolved
Hide resolved
src/NuGetGallery.Core/Login/EditableLoginConfigurationFileStorageService.cs
Outdated
Show resolved
Hide resolved
src/NuGetGallery.Core/Login/EditableLoginConfigurationFileStorageService.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed some of the added files are missing the copyright header comment.
src/NuGetGallery.Core/Login/IEditableLoginConfigurationFileStorageService.cs
Outdated
Show resolved
Hide resolved
src/NuGetGallery.Core/Login/IEditableLoginConfigurationFileStorageService.cs
Outdated
Show resolved
Hide resolved
src/NuGetGallery.Core/Login/IEditableLoginConfigurationFileStorageService.cs
Show resolved
Hide resolved
src/NuGetGallery/Areas/Admin/Controllers/PasswordAuthenticationController.cs
Show resolved
Hide resolved
lyndaidaii
changed the title
admin panel for adding/remove user email address for password authentication.
Admin panel for adding/remove user email address for password authentication.
Apr 20, 2023
zhhyu
reviewed
Apr 20, 2023
zhhyu
reviewed
Apr 21, 2023
zhhyu
reviewed
Apr 21, 2023
lyndaidaii
commented
Apr 21, 2023
src/NuGetGallery.Services/Configuration/LoginDiscontinuationConfiguration.cs
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Apr 24, 2023
src/NuGetGallery/Areas/Admin/Controllers/PasswordAuthenticationController.cs
Outdated
Show resolved
Hide resolved
Next steps:
|
zhhyu
reviewed
Apr 27, 2023
zhhyu
reviewed
Apr 27, 2023
src/NuGetGallery/Areas/Admin/Controllers/PasswordAuthenticationController.cs
Show resolved
Hide resolved
zhhyu
reviewed
Apr 27, 2023
zhhyu
reviewed
Apr 27, 2023
src/NuGetGallery.Core/Login/EditableLoginConfigurationFileStorageService.cs
Show resolved
Hide resolved
zhhyu
reviewed
Apr 27, 2023
src/NuGetGallery/Areas/Admin/Controllers/PasswordAuthenticationController.cs
Outdated
Show resolved
Hide resolved
zhhyu
reviewed
Apr 27, 2023
src/NuGetGallery.Core/Login/EditableLoginConfigurationFileStorageService.cs
Outdated
Show resolved
Hide resolved
zhhyu
reviewed
Apr 27, 2023
src/NuGetGallery.Core/Login/EditableLoginConfigurationFileStorageService.cs
Outdated
Show resolved
Hide resolved
@joelverhagen , @zhhyu , @TheoT12 could you help review again since I applied some changes. Thanks! |
joelverhagen
previously approved these changes
May 9, 2023
agr
reviewed
May 9, 2023
agr
reviewed
May 9, 2023
agr
previously approved these changes
May 9, 2023
src/NuGetGallery/Areas/Admin/Controllers/PasswordAuthenticationController.cs
Outdated
Show resolved
Hide resolved
src/NuGetGallery/Areas/Admin/Controllers/PasswordAuthenticationController.cs
Outdated
Show resolved
Hide resolved
keylime-unicorn
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (in less than 80 characters):
rec-screen.1.webm
Addresses https://github.com/NuGet/Engineering/issues/4731