Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 8 constants for TFM badges and search filters #9729

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

advay26
Copy link
Member

@advay26 advay26 commented Nov 10, 2023

Addresses https://github.com/NuGet/Engineering/issues/5111

We want to add .NET 8 search filters and TFM badges in time for the .NET 8 release.

Search filters:

image

TFM badges:

Previously,
image

image

After the changes,
image

image

NOTE: We usually rely on constants from the NuGet.Frameworks package, but those changes have not been published yet. Once those changes are published with v6.9.0 of the Client SDK, we can remove our Gallery-only constants (Version8 and Net80) and replace them with the appropriate constants from the NuGet.Frameworks package (See https://github.com/NuGet/Engineering/issues/5112).

@advay26 advay26 requested a review from a team as a code owner November 10, 2023 20:57
agr
agr previously approved these changes Nov 10, 2023
mariaghiondea
mariaghiondea previously approved these changes Nov 10, 2023
@advay26 advay26 dismissed stale reviews from mariaghiondea and agr via 485955e November 10, 2023 21:16
@advay26 advay26 requested a review from joelverhagen November 10, 2023 21:17
@advay26 advay26 merged commit ecc32cd into dev Nov 10, 2023
1 check passed
@advay26 advay26 deleted the advay26-net8-filter branch November 10, 2023 21:50
@advay26 advay26 mentioned this pull request Nov 10, 2023
11 tasks
@JonDouglas
Copy link
Contributor

lgtm great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants