link to nugettrends.com #9737
link to nugettrends.com #9737
Conversation
|
Hey @bruno-garcia, Thank you for the PR! Do you think this might fit better in our statistics detail page given what NuGet Trends does? We only expose 6 weeks of data. Your project exposes much more. Do you think your project would complement that instead of where you propose it in this PR? Maybe something like this or some other location on this page? 
I have initial hesitations on just including it on the package details page when the context is more stats oriented. Maybe in the stats/downloads section? Not sure right now. What is the default view for statistics? 2 years? We can add specifics for that and figure out a good spot for it in my opinion. The larger team can likely comment further here too. |
|
Thanks for your input @JonDouglas:
I agree it might fit well in that page, but discoverability is rather low compared with stacking up next to fuget and nuget package explorer. I use both often and I'd love to go straight to nuget trends from the package detail page if that was possible.
Right, but we can specify that via query string. Default 2 years: (results in a redirect adding &months=24):
Got it, looking forward to more input. |
|
Anyone else has input here? I'm still interested in moving forward with adding a way to jump into NuGet Trends from a package details page |
|
@bruno-garcia Can you post a screenshot and edit your PR so people who view this PR can see what is proposed? Additionally, I can evangelize this PR during the holidays so we can get more community perspectives. I do not think we will have a collective decision until the new year however. Many are beginning their vacations here in the USA. |
|
Thank you, @bruno-garcia! It's awesome to see community contributions and the benefit to everyone. |
|
Thanks @mariaghiondea and @JonDouglas for the input. Any chance we'll have previews release of branches (akin Vercel) as a Christmas gift? 😅 |
|
@bruno-garcia after consideration and getting back to this, we're cool to just include it as is and see what feedback we get. Since it is behind a feature flag today, if people do ask about it or want it removed we can track that feedback and make a future decision. But for now, let's just move forward as is! Thanks again for this contribution. For next steps, someone from the @NuGet/gallery-team will help in getting this merged and staging it & eventually pushed to prod over the next few weeks. |
|
That's great! Thanks a lot folks! |
|
Looking forward to next steps! |
|
I forgot to post an update, so thank you for the reminder @bruno-garcia. |
|
Update: we are working on updating our pipelines for compliance reasons and this is on hold until that is done (to not waste efforts). We are trying to complete by end of this month. |
lyndaidaii
dismissed stale reviews from JonDouglas and mariaghiondea
The base branch was changed.
|
This is how UI looks like on package detail page: it looks good to me. @JonDouglas @mariaghiondea, what do you think?
|
|
@bruno-garcia, could you update PR to include those changes? thanks. PR: bruno-garcia#1 |
|
We are closing this issue since we didn't hear back from you, but you can re-open or create new PR if necessary. |
add interface in fake feature service
|
Oh, sorry I didn't check my notifications for a while. Merged the PR @lyndaidaii thanks! |
|
Doesn't seem like I can reopen :~ |
@bruno-garcia I reopened the PR for you. Did you make the changes which was asked above? |
yeah, got merged in! thanks folks. Let me know what's next |
Did the job with that name get removed or renamed? Looks like a branch protection was set but the job is unavailable? |
Apologies for the delay. We need to manually approve each commit to community PRs for our CI. I've done this now.
|
|
woo thanks folks! looks all green 🚀 can't wait to see it live |
|
@bruno-garcia, thank you for your contribution. Will let you know once it's live on NuGet.org. thank you so much! |
* link to nugettrends.com * add interface in fake feature service Co-authored-by: Lynn Dai
|
Hey @bruno-garcia, we detected a bug in this PR where the image does not show up properly I believe it is because the PNG and SVG were not added a content files, similar to the similar links (See FuGet below): NuGetGallery/src/NuGetGallery/NuGetGallery.csproj Lines 1393 to 1394 in c92f5fd Would you be interested in making a quick PR to It looks like we've missed this before (#8385) 😅 |
|
Oh sorry didn't see this before, and I'm going away for a week tomorrow 6 AM. |
Finally back, PR: #9982 |
|
@bruno-garcia, we've enabled this on PROD. Thanks again for your contribution and your stewardship of this awesome community tool! |
NuGet Trends is a .NET Foundation project: https://github.com/dotnet/nuget-trends
Adding a link on the package details' right panel.
Disclaimer: I'm on a Mac and can't really build things without several hacks locally so expect a few CI runs to get this right