Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y Solution for Work Item 1970893 1970906 1987964 #9888

Closed

Conversation

Goodyear2017
Copy link
Contributor

Summary of the changes (in less than 80 characters):

*Disable Bootstrap popover JavaScript on framework filter and support framework badges, keep the popover html layout and CSS, add JavaScript function to make the tooltip popup and make the narrator read the tooltip

  • Add up and down arrow key JavaScript function to make users are able to use arrow keys to move between framework filter mode checkboxes.

Addresses #123

v-ayushchat and others added 4 commits March 20, 2024 10:26
[ReleasePrep][2024.03.19]RI of dev into main
[ReleasePrep][2024.03.21] RI dev to main
…, add arrow keys js event on framework filter mode option checkbox to solve A11y issue
@Goodyear2017 Goodyear2017 requested a review from a team as a code owner March 29, 2024 20:49
@mariaghiondea mariaghiondea requested a review from ryuyu March 29, 2024 20:54
@erdembayar
Copy link
Contributor

erdembayar commented Apr 1, 2024

@Goodyear2017
Usually we merge to dev branch first before merging to main, so please adjust the branch. Otherwise your PR includes many extra changes not related to your effort.
Also linked issue in description is not related to change, either change to correct one or remove it.

@Goodyear2017 Goodyear2017 changed the base branch from main to dev April 1, 2024 20:19
@Goodyear2017
Copy link
Contributor Author

@erdembayar I just made the change, thank you for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants