[UI] Add new theme to Admin pages (part 3) #9891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinrrm
force-pushed
the
dev-martinrrm-admin-pages-3
branch
from
4167ce7 to
afea01b
Compare
martinrrm
changed the base branch from
dev-martinrrm-admin-pages-2
to
dev-martinrrm-feature-new-theme
martinrrm
force-pushed
the
dev-martinrrm-admin-pages-3
branch
from
afea01b to
76abcdc
Compare
martinrrm
force-pushed
the
dev-martinrrm-admin-pages-3
branch
from
76abcdc to
0625f1a
Compare
zhhyu
reviewed
Apr 2, 2024
| @@ -5,6 +5,8 @@ | |||
| // (Initially tried to also force default via `outline: initial`, | |||
| // but that seems to erroneously remove the outline in Firefox altogether.) | |||
| outline: 4px solid -webkit-focus-ring-color; | |||
| outline: 2px solid var(--neutralStrokeFocus2Rest); | |||
There was a problem hiding this comment.
Not very sure. Should the line above this change get deleted?
There was a problem hiding this comment.
Forgot to explain more about this change. var() is not supported by IE, I had a conversation with Joel if this is something we should be worried about but we decided to continue with it and check later if the website is broke for IE (currently there are some CSS that is not supported by IE too).
If line 8 fails, it will try to do line 7, since this is the focus behavior I felt like at least this should be supported always.
zhhyu
reviewed
Apr 2, 2024
zhhyu
reviewed
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new theme to Admin pages Verify API, Feature Flags, Flights, Lucene, Popularity Transfers, Namespaces, Unlist/Relist packages and Validate/Revalidate packages.
Addresses #9866
Spec: https://github.com/NuGet/Engineering/pull/5209
Main Issue: #8773
Verify API
Feature Flags
Flights
Lucene
Popularity Transfers
Namespaces
Unlist/relist packages